Skip to content

readable-stream v3, nodejs v16 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Oct 24, 2023
Merged

readable-stream v3, nodejs v16 #41

merged 16 commits into from
Oct 24, 2023

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 5, 2023 •
edited
Loading

  • BREAKING: Increase minimum Node.js version from 12 to 16
    • ci: Run on Node.js v18,20 instead of 12,14
    • Change recommended Node.js version to 18
  • BREAKING: deps: readable-stream@^2.3.3->^3.6.2
    • deps: replace end-of-stream with port in readable-stream
    • devDeps: replace pump with port in readable-stream

@legobeat legobeat requested a review from a team as a code owner September 5, 2023 21:46
This was referenced Sep 5, 2023
Merged
Closed
@socket-security
Copy link

socket-security bot commented Sep 5, 2023 •
edited
Loading

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
readable-stream 3.6.2 None +0 124 kB matteo.collina
@types/readable-stream 2.3.9...4.0.0 None +1/-2 3.92 MB types
@types/node 14.14.9...20.7.1 None +0/-0 3.89 MB types

🚮 Removed packages: @types/end-of-stream@1.4.0, end-of-stream@1.4.4, pump@1.0.3, typescript@4.1.2

@legobeat legobeat mentioned this pull request Sep 5, 2023
Merged
@legobeat legobeat marked this pull request as draft September 5, 2023 23:08
@socket-security
Copy link

socket-security bot commented Sep 28, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@legobeat legobeat force-pushed the node-16 branch 3 times, most recently from 67980bb to 53c554a Compare September 28, 2023 03:38
@legobeat
devDeps: @types/readable-stream@^2.3.15->4.0.0
fcbbf1e 
We use readable-stream@3 which had no types package published.
Newer versions of @types/readable-stream@4.x cause type issues
@legobeat
deps: replace end-of-stream with readable-stream.finished
27d13c4
@legobeat
devDeps: replace pump with readable-stream.pipeline
0aada39
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Sep 28, 2023
@legobeat legobeat changed the title BREAKING: Increase minimum Node.js version to 16; recommended to 18 readable-stream v3, nodejs v16 Sep 28, 2023
@legobeat legobeat marked this pull request as ready for review September 28, 2023 04:17
@legobeat legobeat mentioned this pull request Sep 28, 2023
Closed
@legobeat legobeat requested review from a team, FrederikBolding and jiexi September 28, 2023 04:19
naugtur
naugtur reviewed Oct 3, 2023
View reviewed changes
naugtur
naugtur reviewed Oct 3, 2023
View reviewed changes
@legobeat legobeat requested a review from naugtur October 3, 2023 13:47
@legobeat legobeat requested a review from a team October 16, 2023 11:36
@legobeat legobeat requested review from a team October 24, 2023 00:27
kumavis
kumavis reviewed Oct 24, 2023
View reviewed changes
kumavis
kumavis reviewed Oct 24, 2023
View reviewed changes
@legobeat legobeat requested a review from kumavis October 24, 2023 07:21
@legobeat legobeat merged commit 3eae042 into MetaMask:main Oct 24, 2023
@legobeat legobeat mentioned this pull request Oct 24, 2023
Merged
2 tasks
@legobeat legobeat mentioned this pull request May 15, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumavis kumavis kumavis approved these changes

@FrederikBolding FrederikBolding Awaiting requested review from FrederikBolding

@jiexi jiexi Awaiting requested review from jiexi

@Mrtenz Mrtenz Awaiting requested review from Mrtenz

@weizman weizman Awaiting requested review from weizman

@danroc danroc Awaiting requested review from danroc

@rekmarks rekmarks Awaiting requested review from rekmarks

@shanejonas shanejonas Awaiting requested review from shanejonas

@NiranjanaBinoy NiranjanaBinoy Awaiting requested review from NiranjanaBinoy

@naugtur naugtur Awaiting requested review from naugtur

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@legobeat @naugtur @kumavis